Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc of Lee2019_SSVEP #546

Merged

Conversation

PierreGtch
Copy link
Collaborator

The table summaries of Lee2019-SSVEP say its trial duration is 1s, but the interval we use is [0,4], same for the textual description.

I updated the tables

@PierreGtch PierreGtch changed the title Fix trial duration in doc of Lee2019_SSVEP Fix doc of Lee2019_SSVEP Mar 6, 2024
@PierreGtch
Copy link
Collaborator Author

PierreGtch commented Mar 6, 2024

The number of channels (16 instead of 62) and sessions (1 instead of 2) are also wrong. I’m fixing it

@bruAristimunha bruAristimunha enabled auto-merge (squash) March 6, 2024 08:55
@bruAristimunha bruAristimunha merged commit 2dd5245 into NeuroTechX:develop Mar 6, 2024
6 of 7 checks passed
@bruAristimunha
Copy link
Collaborator

Thank you @PierreGtch

@PierreGtch
Copy link
Collaborator Author

@bruAristimunha @Sara04 in the doc, is #Trials/class the number in each session or per subject, all sessions together?

At the moment, the doc of Lee SSVEP gives the first one (per session)

@bruAristimunha
Copy link
Collaborator

I think it was built in a simple way, there is an example in the moabb base, generate meta info. Given the first subject, assume that everyone has the same number of trials. Which is not true for some datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants