Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autogen datasets from the specification #14

Closed
ajtritt opened this issue Aug 2, 2017 · 1 comment
Closed

Remove autogen datasets from the specification #14

ajtritt opened this issue Aug 2, 2017 · 1 comment
Assignees
Labels
category: enhancement improvements of code or code behavior

Comments

@ajtritt
Copy link
Member

ajtritt commented Aug 2, 2017

Originally reported by: Oliver Ruebel (Bitbucket: oruebel, GitHub: oruebel)


[Hackathon] At the hackathon it was decided that the datesets created by autogen in the orginal version should be removed. Users will "raise their hand" in case that any specific of these datasets are needed.

Need

  • Remove datasets/attributes listed below from the schema (if not removed already)
  • Update the release notes for autogen to indicate which specific datasets have been removed
  • Update the PyNWB API to remove the removed datasets/attributes also from the API

List of relevant autogen datasets

  • Redundant storage of the path of links stored in the same group:

    • /indexed_timesries_path: Path to which the link “indexed_timeseries” points to
    • /segmentation_interface_path: Path to which the link “segmentation_interface” points to
    • /masked_imageseries_path: Path to which the link “masked_imageseries” points to
    • /clustering_interface_path: Path to which the link “clustering_interface” points to
    • /source_electricalseries_path: Path to which the link “source_electricalseries” points to
    • /<image_stack_name>/original_path: Path to which the link “original” points to
    • /epochs/epoch_x/links: Array of strings of the from “A is path
  • List groups/datasets (of a given type or property) in the current group

    • /interfaces: Names of the groups in the module/group
    • /<image_plane>/roi_list: Names of the roi_name groups in this group
    • /unit_list: Names of the unit_N groups
    • /external_fields: List of fields that are stored as external links
    • /data_link: List of TimeSeries that link to a data field
    • /timestamp_link: List of TimeSeries that link to the same timestamp field
  • /missing_fields: List of required/recommended fields that are missing in the time series (i.e., the file is not NWB compliant)

  • /epochs/epoch_x/tags : A sorted list of the different tags used by epochs

  • /num_samples: Number of samples in data (scalar)

  • /cluster_num: Unique values of the dataset num (i.e., cluster indexes used)


@ajtritt ajtritt added critical category: enhancement improvements of code or code behavior labels Aug 3, 2017
@ajtritt
Copy link
Member Author

ajtritt commented Aug 5, 2017

de2705a

removed the following autogen fields

NWBFile/epochs.tags
NWBFile/epochs/epoch_X.links
TimeSeries.timestamp_link
TimeSeries.extern_fields
TimeSeries.data_link
TimeSeries.missing_fields
Module.interfaces
TimeSeries/num_samples
ClusterWaveforms/clustering_interface_path
Clustering/cluster_nums
EventDetection/source_electricalseries_path
ImageMaskSeries/masked_imageseries_path
IndexSeries/indexed_timeseries_path
RoiResponseSeries/segmentation_interface_path
ImageSegmentation/image_plane/roi_list
MotionCorrection/image_stack_name/original_path
UnitTimes/unit_list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior
Projects
None yet
Development

No branches or pull requests

2 participants