Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parens should not be required around arrow functions with 1 parameter #1

Closed
hisuwh opened this issue May 2, 2017 · 2 comments
Closed

Parens should not be required around arrow functions with 1 parameter #1

hisuwh opened this issue May 2, 2017 · 2 comments

Comments

@hisuwh
Copy link
Contributor

hisuwh commented May 2, 2017 •
edited
Loading

In many cases the type can be inferred and adding parens just adds noise

E.g.
mypromise.then(data => .... ) is arguably cleaner than mypromise.then((data : IData) => ... )

If we know mypromise is of type IPromise<IData> then we don't need the additional type info in the arrow function
@Jameskmonger
Copy link
Contributor

@hisuwh Is this still an issue? Just tried to replicate and didn't have any luck.

@hisuwh
Copy link
Contributor Author

hisuwh commented Sep 12, 2017

@Jameskmonger
This was still presenting due to the comments in the file breaking the linting.
Closing this now

@hisuwh hisuwh closed this as completed Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jameskmonger @hisuwh