This repository has been archived by the owner on Dec 13, 2017. It is now read-only.
fix: remove background fix position #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vidaaudrey thanks for the PR! We will get this reviewed soon. |
jbaxleyiii
suggested changes
Sep 18, 2016
There was a problem hiding this comment.
@vidaaudrey if we remove position: fixed then the background doesn't take up the entire container. We should improve support for scrolling contents however.
Would you be able to adjust this PR to allow the background to still cover the entire preview and allow for scrolling?
I'd be happy to help if you need any guidance!
|
Hi @jbaxleyiii sorry for my late reply. I'm not sure what's the best way to fix the problem. Could you let me know? Thanks. |
|
@vidaaudrey I think #17 will actually fix the issue! I'm going to release it today so we can see! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapper with fixed position will prevent the component area of storybook from scrolling down.