Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

List<CourseSearchEntry> searchCourse #41

Closed
xbdeng opened this issue May 19, 2021 · 5 comments
Closed

List<CourseSearchEntry> searchCourse #41

xbdeng opened this issue May 19, 2021 · 5 comments
Labels
Invalid This doesn't seem right

Comments

@xbdeng
Copy link

xbdeng commented May 19, 2021

There are some problems with this function.

  1. What is the searchName, should I use a Fuzzy query?

  2. searchCourseType If a student doesn't have a major, what is the searchCourseType.

@jwnhy
Copy link
Collaborator

jwnhy commented May 19, 2021

  1. Please read the document.
    * @param searchName search course name. Rule: searchName in "course.name[section.name]"
  2. Major is a must, also read the document.

@jwnhy jwnhy added the Invalid This doesn't seem right label May 19, 2021
@xbdeng
Copy link
Author

xbdeng commented May 20, 2021

Sorry, the document is not clear enough.

Should I use a Fuzzy query to search the searchName

I can't understand the search course name. Rule: searchName in "course.name[section.name]" what is "in" ?

@NewbieOrange
Copy link
Owner

what is "in" ?

a in b = b.contains(a)

@xbdeng
Copy link
Author

xbdeng commented May 20, 2021

如果学生必须有专业,那么当调用 void removeMajor(int majorId); 时,这个专业的所有学生都会被一起删除吗?这不符合常理。

@NewbieOrange
Copy link
Owner

如果学生必须有专业,那么当调用 void removeMajor(int majorId); 时,这个专业的所有学生都会被一起删除吗?

Yes.

这不符合常理。

For simplicity's sake, we make all remove methods cascading delete.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants