Fix tests on Python 3. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Syntax fixes. Sometimes we were doing an unneeded `raise t, v, tb`, so stop doing that. Where we do need that, use `six.reraise`. Also delete the temporary variables to avoid reference cycles. - Require a newer six for the same reason as above. - d.iteritems -> six.iteritems(d) - plistlib API changed
|
Thanks. |
|
Curious question.. any reason to have logger = __import__('logging').getLogger(__name__)after declaring all imports? Carlos |
|
Yes, it's a PEP8 style guideline: imports go first, before any variable declarations. pylint produces a |
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raise t, v, tb, so stop doing that. Where we do need that, usesix.reraise.Also delete the temporary variables to avoid reference cycles.
unicodeorbasestring. One of them needs to be tightened on Python 2, left anXXXcomment about that.Fixes #17