One more minor optimization for when we max out our hashing ability.

OpenNTI · Sep 8, 2016 · acfbf04 · acfbf04
1 parent 65c0c31
commit acfbf04
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/nti/schema/eqhash.py b/src/nti/schema/eqhash.py
@@ -198,6 +198,11 @@ def _hash(values):
             except TypeError:
                 # Snap. Something changed.
                 for i, value in enumerate(values):
+                    if transformers[i] is _superhash:
+                        # We've reached our limit. Nothing else to do
+                        # for this one.
+                        continue
+
                     if transformers[i] is _superhash_force:
                         try:
                             _superhash_force(value)

diff --git a/src/nti/schema/tests/test_eqhash.py b/src/nti/schema/tests/test_eqhash.py
@@ -112,6 +112,12 @@ class AThing(object):
         assert_that(hash(thing_superhash2), is_(hash(thing_superhash)))
         assert_that(hash(thing_superhash2), is_(hash(thing_superhash)))
 
+        # One more mutation for coverage
+        thing_superhash.a = athing
+        thing_superhash2.a = athing
+        assert_that(hash(thing_superhash2), is_(hash(thing_superhash)))
+        assert_that(hash(thing_superhash2), is_(hash(thing_superhash)))
+
 
     def test_eq_hash_classes(self):
         # Default doesn't include classes