Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on plone.i18n in favor of nti.i18n. #13

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

jamadden
Copy link
Member

@jamadden jamadden commented Jul 6, 2017

No description provided.

@jamadden jamadden requested a review from papachoco July 6, 2017 22:42
@jamadden
Copy link
Member Author

jamadden commented Jul 6, 2017

The simplest transition is to be sure that plone.i18n is simply not installed and cut over to importing the new interface classes. The next simplest transition, or an intermediate step, is just to be sure that it's not being configured yet continue using the old classes---they'll get the new implementation thanks to inheritance.

If anybody is still configuring plone.i18n after this is merged, then we would be working with two different data sets if we used both interfaces. The only reason I can think of to do that would be to get access to all of the flag resources; I don't think we use those in our app, although we could with a little bit of glue code if we wanted to.

@jamadden jamadden merged commit 1097bf2 into master Jul 6, 2017
@jamadden jamadden deleted the use-nti-i18n branch July 6, 2017 22:55
@jamadden
Copy link
Member Author

jamadden commented Jul 6, 2017

1.3.0 is on PyPI.

@papachoco
Copy link
Contributor

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants