Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonschema turns the new abstract classes into something concrete. #30

Merged
merged 1 commit into from Sep 10, 2018
Merged

jsonschema turns the new abstract classes into something concrete. #30

merged 1 commit into from Sep 10, 2018

Conversation

jamadden
Copy link
Member

No description provided.

@jamadden jamadden mentioned this pull request Sep 10, 2018
Merged
@jamadden
Copy link
Member Author

The builds have actually finished and are green, but right now the status still hasn't updated here.

@papachoco
Copy link
Contributor

LGTM

papachoco
papachoco approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@papachoco papachoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamadden jamadden merged commit f306a99 into master Sep 10, 2018
@jamadden jamadden deleted the issue29 branch September 10, 2018 20:51
@jamadden jamadden mentioned this pull request Sep 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papachoco papachoco papachoco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamadden @papachoco