Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to zope.interface 5.3 and use custom types to always create persistent sub-objects in BTreeLocalAdapterRegistry. #43

Merged
merged 3 commits into from Mar 23, 2021

Conversation

jamadden
Copy link
Member

Remove the on-demand migration, which was slow and buggy.

You must call BTreeLocalSiteManager.rebuild() on each persistent BTreeLocalSiteManager.

Fixes #41 and closes #42.

…rsistent sub-objects in BTreeLocalAdapterRegistry.

Remove the on-demand migration, which was slow and buggy.

You *must* call BTreeLocalSiteManager.rebuild() on each persistent BTreeLocalSiteManager.
Copy link
Contributor

@jzuech3 jzuech3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. We need to migrate and rebuild the existing registries, correct?

@jamadden
Copy link
Member Author

Precisely.

@jamadden jamadden merged commit 4f631fb into master Mar 23, 2021
@jamadden jamadden deleted the zope-interface-5.3 branch March 23, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BTree conversion: Wide but shallow _adapters can lose data in ZODB
2 participants