Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat with sphinx 2.0 #36

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Conversation

keszybz
Copy link
Contributor

@keszybz keszybz commented Jun 3, 2019

@jamadden
Copy link
Member

jamadden commented Jun 3, 2019

Can you please describe what problem this solves? We already support and test on Sphinx 2

@keszybz
Copy link
Contributor Author

keszybz commented Jun 4, 2019

It was already deprecated in sphinx 1.6, and was removed at some point:
https://github.com/sphinx-doc/sphinx/blob/6ef08a42df4534dbb2664d49dc10a16f6df2acb2/sphinx/application.py#L916. sphinxcontrib-programoutput was faling to build in Fedora rawhide: https://bugzilla.redhat.com/show_bug.cgi?id=1716531.

@jamadden jamadden merged commit fb3bf29 into OpenNTI:master Jun 4, 2019
@jamadden
Copy link
Member

jamadden commented Jun 4, 2019

Ah, I see now, it was just in our documentation configuration, not actually in the project's code. readthedocs builds with sphinx < 2, so it wasn't a problem there.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants