Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If DATADOG_HOST points to a socket file, and the file goes away, bifrost never notices.. #46

Open
diranged opened this issue Aug 7, 2019 · 0 comments

Comments

@diranged
Copy link

diranged commented Aug 7, 2019

If you set DATADOG_HOST to point to a unix socket file (ie, /var/run/dogstatsd/dsd.sock) and for some reason that file goes away (lets say you upgrade the datadog agent and it restarts the process) - bifrost never notices that it went away and silently fails forever. Because of this silent failure, you lose all your metrics .. but you don't know why.

We shouldn't crash when this happens .. but, we should at some point try to get that socket back. Maybe every 30s? 60s? Then we should throw an error in the logs to help the user diagnose the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant