-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: feature: Yield Sharing #1105
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rackstar
commented
May 6, 2024
Comment on lines
91
to
92
uint currentRate = getCurrentTokenPrice(); | ||
uint withdrawAmount = (principalAmount * initialRates[msg.sender]) / currentRate; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User withdrawal
- pull the latest oracle value
- withdrawable amount = deposit * initial_rate / current_rate
- ex: 100 -> 100 * 1.2 / 1.3 = 92.30769230769231
* add recalculateAvailableYield on every operation
rackstar
force-pushed
the
feature/yield-vault
branch
from
May 9, 2024 22:15
9c5e74d
to
22344ea
Compare
rackstar
force-pushed
the
feature/yield-vault
branch
from
May 9, 2024 22:15
22344ea
to
d5021b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #1102
YieldDeposit is not a great contract name, happy to hear better suggestions.
Tasks
https://nexusmutual.slack.com/archives/C06R21K595F/p1711633388892209
Cover buy
User withdrawal
Changes proposed in this pull request
Test plan
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: