Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make first NFT token id 1 instead of zero (StakingNFT and CoverNFT) and add totalSupply() #619

Closed
shark0der opened this issue Jan 11, 2023 · 0 comments · Fixed by #692
Closed

Make first NFT token id 1 instead of zero (StakingNFT and CoverNFT) and add totalSupply() #619

shark0der opened this issue Jan 11, 2023 · 0 comments · Fixed by #692
Assignees
@0xdewy
Labels
enhancement New feature or request launch
Milestone
V2 implementation...

Comments

@shark0der
Copy link
Collaborator

shark0der commented Jan 11, 2023 •
edited

As a consequence we will get rid of the MAX_UINT flag and we'll be able to use 0 again, for both requestAllocation and buyCover.
@shark0der shark0der self-assigned this Jan 11, 2023
@shark0der shark0der added this to the V2 upgrade ready milestone Jan 11, 2023
@shark0der shark0der changed the title Make first NFT token id 1 instead of zero (StakingNFT and CoverNFT) Make first NFT token id 1 instead of zero (StakingNFT and CoverNFT) and add totalSupply() Jan 11, 2023
@shark0der shark0der mentioned this issue Jan 11, 2023
Merged
9 tasks
@roxdanila roxdanila assigned 0xdewy and unassigned shark0der Jan 18, 2023
@roxdanila roxdanila added enhancement New feature or request and removed feature labels Jan 23, 2023
@0xdewy 0xdewy mentioned this issue Jan 24, 2023
Closed
9 tasks
@roxdanila roxdanila linked a pull request Jan 25, 2023 that will close this issue
Chore: Use 0 instead of uint256.max as flag to signal minting new nft. Add totalSupply to CoverNFT #655
Closed
9 tasks
@0xdewy 0xdewy mentioned this issue Feb 6, 2023
Merged
9 tasks
@0xdewy 0xdewy linked a pull request Feb 6, 2023 that will close this issue
Chore: Use 0 instead of uint256.max as flag to signal minting new nft #692
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xdewy 0xdewy

Labels
enhancement New feature or request launch
Projects
None yet
Milestone
V2 implementation freeze
3 participants
@shark0der @0xdewy @roxdanila