Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5. Cover Edit: Explore combining increase amount & extend period into one function #889

Open
roxdanila opened this issue Jun 27, 2023 · 0 comments
Open

5. Cover Edit: Explore combining increase amount & extend period into one function #889

roxdanila opened this issue Jun 27, 2023 · 0 comments
Assignees
@danoctavian
Labels
feature

Comments

@roxdanila
Copy link
Contributor

roxdanila commented Jun 27, 2023 •
edited by danoctavian

Conclusion:

The 2 functionalities can be merged into one function handling both increasing amount and period as shown here:

smart-contracts/contracts/modules/cover/Cover.sol

Line 413 in 5ffd351

function requestEditAllocations(

The PR implementing both increasing amount and period can be found here:

#916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danoctavian danoctavian

Labels
feature
Projects
Engineering Tracker 💻
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danoctavian @roxdanila