Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dex): solve constant product invariant with uneven weights #141

Closed
Tracked by #261
NibiruHeisenberg opened this issue Apr 7, 2022 · 3 comments
Closed
Tracked by #261

Comments

@NibiruHeisenberg
Copy link
Contributor

NibiruHeisenberg commented Apr 7, 2022

Currently the constant product invariant only supports two assets (x and y) and works really well with equal weights, but not with unequal weights because the floating point exponentiation leads to loss of precision, which leads to significant slippage at large numbers.

For now, the constant product invariant only supports equal weights but for exploring how to support unequal weights would be a huge value add.

@NibiruHeisenberg
Copy link
Contributor Author

10/31: lower priority

@matthiasmatt
Copy link
Contributor

Also this will break the single asset join

@matthiasmatt
Copy link
Contributor

Should we remove weights all together?

@matthiasmatt matthiasmatt removed this from the Testnet V2 - NibiSwap milestone Nov 29, 2022
@k-yang k-yang closed this as completed Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants