Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo clears background image #10

Closed
waltermvp opened this issue Aug 22, 2016 · 8 comments
Closed

Undo clears background image #10

waltermvp opened this issue Aug 22, 2016 · 8 comments

Comments

@waltermvp
Copy link

waltermvp commented Aug 22, 2016

When creating a Canvas with a background image with Canvas(backgroundImage: UIImage.init(named: "Image")!) calling undo wipes everything including the background image.

The undo functionality should undo the first drawing but not clear the background image. It seems the first drawing and the setting of the image are merged into the first action.

@waltermvp
Copy link
Author

Also is there way to clear all the undos?

@Nicejinux
Copy link
Owner

Oh.. I see.
I'll fix it.
and I'll check clear undo

Thanks.

@waltermvp
Copy link
Author

@Nicejinux thanks for the quick response.

@waltermvp
Copy link
Author

waltermvp commented Aug 23, 2016

Any estimate till when it's fixed? Id be happy to submit a PR if it helps :)

@Nicejinux
Copy link
Owner

Oh. sure. You can submit PR anytime~~

@waltermvp
Copy link
Author

@Nicejinux great ill try to see if i can get it done tonight

@Nicejinux
Copy link
Owner

Fixed.
Please update and check.

Thanks.

@waltermvp
Copy link
Author

@Nicejinux works perfectly :) thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants