Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper Stop Mechanism for Downloads #4

Closed
nlogozzo opened this issue Oct 13, 2022 · 2 comments
Closed

Proper Stop Mechanism for Downloads #4

nlogozzo opened this issue Oct 13, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@nlogozzo
Copy link
Member

Currently, if downloads are running and the window is closed, the downloads will continue in the background and the application will stop once they all finish. This is unexpected behavior, as all downloads should hault once the window is closed and the application should exit immediately.

Implementing a proper stop mechanism for downloads would also allow us to have a stop button in the download row as well as a confirmation dialog when the window is closing and downloads are still running.
@nlogozzo nlogozzo added feature New feature or request bug Something isn't working in-beta This issue is fixed in a beta version and removed feature New feature or request labels Oct 13, 2022
@nlogozzo
Copy link
Member Author

https://github.com/nlogozzo/NickvisionTubeConverter/releases/tag/2022.10.2-beta2

@nlogozzo
Copy link
Member Author

https://github.com/nlogozzo/NickvisionTubeConverter/releases/tag/2022.10.2

@DaPigGuy DaPigGuy removed the in-beta This issue is fixed in a beta version label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DaPigGuy @nlogozzo