-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Sponsorblock support #552
Comments
Do you think this should be a per-download setting (advanced options) or a global setting (Preferences)...I feel like maybe global on this one cause i'm sure if a user sponsorblocks they'd want to do it for all videos... |
I believe global should be the way to go on this one, it's how its support is usually built on apps that support it (YT Vanced and NewPipe, for example) |
https://github.com/NickvisionApps/Parabolic/releases/tag/2023.8.3-rc1 should be on flathub beta soon...whenever gnome gitlab is up again |
Sorry guys, I'm not sure this feature is working correctly. I enabled it in the settings and I see [SponsorBlock] in the log, but the final video is unchanged |
SponsorBlock is a community-driven database. This means that your video would need to be submitted to SponsorBlock by someone who has watched it and has marked all of the places where sponsors are mentioned. Then SponsorBlock will remove the sponsors from the video in Parabolic. See more info here: https://sponsor.ajay.app/about/ |
I know how sponsorblock works, I use it regularly on my browser... I tested the feature with this video (as you can see, there's a big beautiful green sponsor segment). This is Parabolic's log:
From the log, I assume that I correctly enabled the SponsorBlock feature and it correctly detected the sponsored segments. However, the final video still has the sponsored segment and, at least according to mpv, the segment isn't tagged as sponsored. Please, next time ask for more information before assuming I don't know what I'm talking about (which absolutely might be the case). |
@BuonHobo What I find weird is that Parabolic is downloading the file as an 3gp when that's not a file format supported by Parabolic. Do you have |
I think 3gp was selected because I chose to download the video with the smallest possible resolution (since I just needed the log for demonstration purposes). Anyway yes, I had
|
Figured out the issue! We were reading SponsorBlock information, but we then had to pass said read information to yt-dlp again for removal. |
I was going to create a single issue for both the things I'd like to see, but this one might be a tougher pill to swallow and is probably going to be more difficult to support.
Sponsorblock, for the unaware, is an extension that helps you to get rid of in-video ads and breaks, which has great support in yt-dlp.
Once again, using the example I used on the other feature request I created, it could really come in handy for events like Flock to Fedora and GUADEC, where you could use the extension to tag which parts of the stream were breaks between each talk (which would already help a lot those that decide to watch the stream's VOD later), and when you export the video you can use
--sponsorblock-mark all --sponsorblock-remove all
in conjunction with--split-chapters
to not only have the talks automatically trimmed and ready to upload, you also get zero videos containing the breaks.The text was updated successfully, but these errors were encountered: