Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep subtitles as separate files if embedding failed #597

Closed
fsobolev opened this issue Sep 19, 2023 · 1 comment · Fixed by #602
Closed

Keep subtitles as separate files if embedding failed #597

fsobolev opened this issue Sep 19, 2023 · 1 comment · Fixed by #602
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Milestone

Comments

@fsobolev
Copy link
Member

fsobolev commented Sep 19, 2023

Another idea would that in case of an error linked to the subtitles conversion or the subtitles embedding, the original sub file is kept (.srt or .vtt), as most media players can automatically play the video with the corresponding sub file (if it has the same name).

Originally posted by @Philetjosie in #596 (comment)

@fsobolev fsobolev added the feature New feature or request label Sep 19, 2023
@fsobolev fsobolev added this to the V2023.9.1 milestone Sep 19, 2023
@nlogozzo nlogozzo added the in-beta This issue is fixed in a beta version label Sep 25, 2023
@nlogozzo
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants