Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No timestamp data in trainset #469

Closed
tseesurenb opened this issue Jun 25, 2023 · 1 comment
Closed

No timestamp data in trainset #469

tseesurenb opened this issue Jun 25, 2023 · 1 comment

Comments

@tseesurenb
Copy link

Hi all,

I recently discovered that the trainset class design has omitted the "timestamp" feature, which I believe is a significant oversight. This limitation restricts the utilization of this excellent framework for those interested in implementing temporal effects. Do you have any suggestions on how to redesign the Training class to include the timestamp?

Best regards,
Tse

Description

Steps/Code to Reproduce

Expected Results

Actual Results

Versions

@NicolasHug
Copy link
Owner

Try #52 (comment)

I added the timestamps originally thinking I'd implement predictors that use them, but ended up not doing so. So it's more of an unsupported feature at this point (and a wonky design but 🤷 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants