LeaderBoard Styling #4
Conversation
There was a problem hiding this comment.
Hi @Nicolaswg ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/style.css
Outdated
| .header { | ||
| display: var(--display-flex); | ||
| width: 100vw; | ||
| padding: 20px; | ||
| margin-bottom: 100px; | ||
| } |
There was a problem hiding this comment.
- There is a little overflow that we can fix easily by just changing the width of the header to a percentage instead of the view width(VW).
We want to avoid the next:
See that blue background right at the end?
There was a problem hiding this comment.
Hi @Nicolaswg,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Main Point
🦅
Set up Project 💻
npm install).npm run build) and finally type (npm run start).