Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicotine+ 1.4.1 don't handle invalid characters in Windows #101

Closed
aquila-XP opened this issue Dec 22, 2019 · 1 comment · Fixed by #209
Closed

Nicotine+ 1.4.1 don't handle invalid characters in Windows #101

aquila-XP opened this issue Dec 22, 2019 · 1 comment · Fixed by #209

Comments

@aquila-XP
Copy link

Hi gfarmerfr,

Please fix these bugs that I encountered on the Windows 10 x64 OS:
1-st bug: It seems that Nicotine+ 1.4.1 is not handling invalid characters on Windows OS.
I tried to download a file with this name: http:::www.war3z.altervista.org:madonna.mp3 from a user that is using a Mac-OS and I get these messages:

Failed download: user murgoros, file @@fujqk\Downloads\Keygen App 2018 v1 2 0-macOS-CASHMERE\Keygen.App.2018.v1.2.0-macOS-CASHMERE\Keygen App.app\Contents\Resources\dosdevices\z:\Users\murgocisugipule\Desktop\Documents\http:::www.war3z.altervista.org:madonna.mp3
Download I/O error: [Errno 22] invalid mode ('ab+') or filename: u'F:\\nicotine-downloads\\incompletefiles\\INCOMPLETEcf88f4d5033c568bb5f57a62c35e825ahttp:::www.war3z.altervista.org:madonna.mp3'

2-nd bug: When I try to download multiple files with the same filename, but different in size, the first file is downloaded in "nicotine" folder, the next two files are stuck in "incompletefiles" folder with these filenames: INCOMPLETE[hash1]filename.ext and INCOMPLETE[hash2]filename.ext and the following files don't download anymore.
Can you please change the code of Nicotine+ 1.4.1 so that will download multiple files with the same filename by adding (1), (2), (3) ... like these: filename(1).ext, filename(2).ext, filename(3).ext and so on.

@mathiascode
Copy link
Member

On Linux, the second bug doesn't seem to occur on the master branch at least. We don't have any Windows builds set up for testing (yet) though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants