Hot keys

[82d]

There is a great lack of standard manipulations such as Ctrl-Z in the fill line to reverse the input history. This needs to be implemented globally.
Ctrl-C to copy the selected element (copying the path should remain in the context menu.). The update mentioned this feature, but I still haven't seen it. The implementation can be copied from the official client, there everything is fine with it, here it is not enough. That is, I chose an element, whether it is a file or a directory, when clicked, the name of the element itself is copied for the convenience of further search. This function is needed globally*.

Nicotine+ version 3.0.1
FreeBSD 12.2 amd64

[mathiascode]

There is a great lack of standard manipulations such as Ctrl-Z in the fill line to reverse the input history. This needs to be implemented globally.

Anything else in addition to Ctrl-Z?

Ctrl-C to copy the selected element (copying the path should remain in the context menu.). The update mentioned this feature, but I still haven't seen it. The implementation can be copied from the official client, there everything is fine with it, here it is not enough. That is, I chose an element, whether it is a file or a directory, when clicked, the name of the element itself is copied for the convenience of further search. This function is needed globally*.

This functionality works fine on my system, and is implemented for all views containing file lists (7d104e0). Does Ctrl-C have no effect on your end?

[82d]

auto-completion of the search often interferes if you want to add a secondary insert to the line by clicking the mouse wheel.
thereby pushing the data out of the clipboard,
you need to pre-enable disabling the auto-complete option in the settings.

Ctrl + C absolutely does not work on either FreeBSD or Linux. checked in the stable
3.0.2

[mathiascode]

Ctrl + C absolutely does not work on either FreeBSD or Linux. checked in the stable
3.0.2

I assume you're using a non-Latin keyboard layout? Looks like a couple of our keyboard shortcuts need to be modified to take other keyboard layouts into account.

[82d]

$locale
LANG=ru_RU.UTF-8
LC_CTYPE="ru_RU.UTF-8"
LC_COLLATE="ru_RU.UTF-8"
LC_TIME="ru_RU.UTF-8"
LC_NUMERIC="ru_RU.UTF-8"
LC_MONETARY="ru_RU.UTF-8"
LC_MESSAGES="ru_RU.UTF-8"
LC_ALL=ru_RU.UTF-8

[mathiascode]

Ctrl-C should now work in the unstable version. Can you verify that this is the case?

[82d]

Nicotine+ version 3.0.3.dev1
FreeBSD 12.2 amd64
it doesn't work ...

[mathiascode]

Who knew keyboard shortcuts are so difficult to implement... What's your GTK version, and could you check if it's broken in Linux too? For me, it works on Arch Linux with the Russian keyboard layout enabled, GTK 3.24.26.

[82d]

FreeBSD gtk2-2.24.33, gtk3-3.24.24 Xfce
Arch Linux gtk2 2.24.33-1 gtk3 1:3.24.25-1 Xfce
It doesn't work on both systems.

[82d]

3.0.3.dev1 ctrl + c still doesn't work

[mathiascode]

Do the T (abort), R (retry) or Delete (abort and clear) keys work on transfers in the download/upload views?

[82d]

T works, Delete works. R doesn't work. when I press R, it behaves like a normal character, calling the search bar. all keys behave the same regardless of switching the layout.

[mathiascode]

Thanks, at least the key mapping seems to work. Does 239ec4c help with the Ctrl-C situation?

[82d]

No, it's still the same

[mathiascode]

Could you test the following branch, enable "statistics" debug logging in the log pane, and post the output you get when pressing Ctrl-C in the search list? https://github.com/mathiascode/nicotine-plus/tree/shortcutlog

[82d]

I put all the checkboxes, but when you click the log is not written.

I press a large number of times ctrl +c in the search window on the lines with names disconnected for a while from the server, the log does not move.

[82d]

there is no need to choose anything in the settings?

[mathiascode]

there is no need to choose anything in the settings?

There's nothing in the settings that control keyboard shortcuts, so that shouldn't be necessary.

I'm rather confused at this point. No logging would mean that the whole key-press-event isn't activated for some reason, but the working shortcuts in downloads/uploads would imply otherwise for those lists. I added the same logging for the download list, could you check if anything happens when you press keys there? https://github.com/mathiascode/nicotine-plus/tree/shortcutlog

[82d]

ok I'll check now
ok I'll check now

[82d]

when I do copy file path, copy URL, copy folder URL through the context menu in the downloads window, nothing happens in the logs.

[mathiascode]

That's to be expected, there's only logging for keyboard presses.

[82d]

I didn't quite understand what to do in the last experience? I tried it with a different keyboard, without any changes. what else can I do for the test?

[mathiascode]

Is anything logged if you press keys while a file is selected in your list of downloads (where you previously tested the T (abort), R (retry) or Delete (abort and clear) keys)? Ideally I'd like to know what the logged Ctrl-C key combination looks like on your system, so I can see why the Ctrl-C functionality is not being activated.

[82d]

ctrl

KeyRelease event, serial 37, synthetic NO, window 0x6c00001,
    root 0x14b, subw 0x0, time 16828388, (-296,226), root:(1101,1326),
    state 0x14, keycode 37 (keysym 0xffe3, Control_L), same_screen YES,
    XLookupString gives 0 bytes: 
    XFilterEvent returns: False

c

KeyPress event, serial 37, synthetic NO, window 0x6c00001,
    root 0x14b, subw 0x0, time 16857106, (4,-11), root:(1401,1089),
    state 0x10, keycode 54 (keysym 0x63, c), same_screen YES,
    XLookupString gives 1 bytes: (63) "c"
    XmbLookupString gives 1 bytes: (63) "c"
    XFilterEvent returns: False

ctrl + c

KeyPress event, serial 37, synthetic NO, window 0x6c00001,
    root 0x14b, subw 0x0, time 16906466, (9,-13), root:(1406,1087),
    state 0x114, keycode 54 (keysym 0x63, c), same_screen YES,
    XLookupString gives 1 bytes: (03) ""
    XmbLookupString gives 1 bytes: (03) ""
    XFilterEvent returns: False

via xev

[mathiascode]

Thanks, looks like your Ctrl key is reported as Super_L (133), while it's Control_L (37) on my system. Have the keys been swapped?

[82d]

I'm sorry, I pressed the wrong button. now I have fixed everything as it is. ctrl has the code 37.

[82d]

I sent the LOG file to the mail from a short session where I used ctrl + c, R, T many times.
I also noticed that R acts resume only in the download window.
just because of the heavy turnover of logs, I couldn't identify anything useful.

[mathiascode]

I also noticed that R acts resume only in the download window.

Looks like this shortcut needs to be added for the upload window. I'll do this soon.

I don't see the expected output in the log. Can you verify that the following line exists in your cloned copy of the repo? mathiascode@5e9a6c1

If not, try cloning with this command: git clone -b shortcutlog --depth 1 https://github.com/mathiascode/nicotine-plus

[82d]

there was no this line, installed (git clone). reinstalled it in a new way, now it is being copied. but only file patch.

04:16:13 Keys pressed in download list: <flags GDK_CONTROL_MASK | GDK_MOD2_MASK of type Gdk.ModifierType> 54
04:16:13 Keys pressed in download list: <flags GDK_CONTROL_MASK | GDK_MOD2_MASK of type Gdk.ModifierType> 54
04:16:13 Keys pressed in download list: <flags GDK_CONTROL_MASK | GDK_MOD2_MASK of type Gdk.ModifierType> 54

[mathiascode]

I didn't realize SoulseekQt allows highlighting individual columns. I think GTK only allows highlighting a full row. In that case, we could somewhat easily copy the folder and file name in the grouped mode, depending on the selected row, while ungrouped mode would require more thought. Which list mode (grouped by folder, grouped by user, ungrouped) do you use, and what data do you usually need for searching?

Since the shortcuts work in the repo you cloned, they should work in master/unstable too. Can you verify that you have the latest changes from master, and check if Ctrl-C copies the file path there?

[82d]

in the master version, everything worked.
in most cases, I need to copy only the name of the file or the name of the directory without the full path (let the option to copy the full path or the links remain in the context menu). ideally, I would like to see individual blocks copied . such as User, Patch, Filename, Status, Queue, Size, Time. it would be nice to add copying nicknames from Buddy List

[gits68]

Hi, Could you add Ctrl-Tab/Shift-Ctrl-Tab to switch to next/previous tab ?
For instance, it switches from next/previous field...

[slook]

I agree @gits68 it would indeed be very helpful to add Ctrl+Tab / Shift+Ctrl+Tab to switch to next / previous Search and Browse Files sub tabs.

Additionally, main top tab bar navigation with Ctrl+1 thru Ctrl+9 seems to work well in Chromium based browsers and the like.

I have not yet found any good way of switching between window tabs nor sub tabs using the keyboard in N+ for example currently the only way getting to the Search Files tab is F10 > Alt+M > Alt+S and getting to the Downloads tab is F10 > Alt+M > Alt+D etc.

Unfortunately, once in the Search or Browse Files sub tab the only way of navigating to the desired tab is Ctrl+W multiple times to close each tab until the desired one is reached.

Ctrl+? does not show the Keyboard Shortcuts window as expected. (Edit: see issue #1484)

This is a serious accessibility issue because seems to be the only thing that prevents Nicotine+ plus from being used without a pointing device.

Nicotine+ 3.1.1 • GTK 3.24.21

[mathiascode]

Closing in favor of #1489 #1490