Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sortable audio properties/quality column #2296

Closed
mathiascode opened this issue Jan 1, 2023 · 2 comments · Fixed by #2564
Closed

Add sortable audio properties/quality column #2296

mathiascode opened this issue Jan 1, 2023 · 2 comments · Fixed by #2564
Milestone

Comments

@mathiascode
Copy link
Member

Describe the solution you'd like

The bitrate column isn't very useful for lossless audio files, but it can be sorted to show higher quality files first.

SoulseekQt has an Attributes column that shows bit depth and sample rate for lossless files, and bitrate for lossy files. Unfortunately, the column isn't sortable.

I want the best of both worlds, where the bitrate is always used as the internal sort value, but the value shown in the GUI is similar to SoulseekQt. This allows us to keep displaying high quality files first.

Additional context


@mathiascode
Copy link
Member Author

The bitrate result filter requires some thought. It could probably be turned into a "quality" filter somehow, where you can enter bitrates, bit depths and sample rates.

@slook
Copy link
Member

slook commented Jan 2, 2023

Sample Rate data is not displayed anywhere at the moment, for lossless files if it is listed could probably add it to the file properties dialog.

SoulseekQt has an Attributes column

Why not label our column the same then, since "Properties" does seem to refer to other properties like size and duration as well.

a "quality" filter somehow, where you can enter bitrates, bit depths and sample rates.

Suppose having suffixes such as "k", "bits", "khz", etc, albeit the structure of syntax and documentation would be rather complex.

Perhaps if the digit is within a certain range, then this could (somewhat) reliably infer the desired unit, such as <=32 would infer "bits", <~11500 would infer "bitrate" and >~11500 would infer sample rate is the intended unit.

"Quality" might be a good name for the column header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants