Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-label #481

Closed
ecarrera opened this issue Aug 12, 2020 · 3 comments
Closed

aria-label #481

ecarrera opened this issue Aug 12, 2020 · 3 comments
Labels

Comments

@ecarrera
Copy link

ARIA input fields do not have accessible names

Users of screen readers and other assistive technologies need information about the behavior and purpose of controls on your web page. Native HTML controls like buttons and radio groups come with that information built in. For custom controls you create, however, you must provide the information with ARIA roles and attributes.

To be announced properly by assistive technologies, both native HTML controls and custom ARIA controls must have accessible names that convey their purpose.

From: https://web.dev/aria-input-field-name/

Solution:

I added the aria-label prop into vue-slider.tsx

@Prop() ariaLabel?: string

...

aria-label={this.ariaLabel}

I tested it and it's working. Then tried to upload the branch but its locked.

@NightCatSama
Copy link
Owner

Thank you for your feedback. In version 3.2.4, you can set custom attributes on dot.

document: https://nightcatsama.github.io/vue-slider-component/#/api/props?hash=dotattrs

@ecarrera
Copy link
Author

Thanks @NightCatSama, running on 3.2.4. 💪🏻

@RobertJGabriel
Copy link

@NightCatSama Fantasic!!! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants