Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish MessageFormat implementation #17

Closed
NightOwl888 opened this issue Sep 30, 2019 · 1 comment
Closed

Finish MessageFormat implementation #17

NightOwl888 opened this issue Sep 30, 2019 · 1 comment
Labels
is:feature pri:low up for grabs This issue is open to be worked on by anyone

Comments

@NightOwl888
Copy link
Owner

The MessageFormat class is only partially implemented. It was actually only ported for the use of ChoiceFormat, which is required by Transliterator to load resources. But it currently doesn't work much beyond that purpose.

MessageFormat has many dependencies, including DateFormat and RuleBasedNumberFormat that would also need to be ported in order to make it complete.

Ideally, these format classes should implement ICustomFormatter and IFormatProvider to be compatible with string.Format() and other .NET APIs. Also, they should ideally not utilize CultureInfo as a property themselves, but be passed a CultureInfo instance when they do their work. That might not be feasible in all cases (such as rule-based number format). More analysis is required to work out the best approach for .NET compatibility.

@NightOwl888
Copy link
Owner Author

For now, this class has been marked internal so it can be redesigned and dealt with at some later point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:feature pri:low up for grabs This issue is open to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

1 participant