Use require.resolve when deleting key in require.cache

[ofabel]

I would suggest to replace the following line:

twing/src/lib/cache/filesystem.ts

Line 47 in 56e186b

delete cache[modulePath];

With this:
delete cache[require.resolve(modulePath)];

Why is this necessary? Packages like https://github.com/vercel/ncc use their own require.cache implementation. This small fix ensures twing's cache to work as expected when bundled with ncc.

[ofabel]

Nevermind, a working solution is far more complicated. I solve it by implementing a own cache.

[ericmorand]

Awesome. Was it easy? I focused on having the API easy to inherit and extend so let me know if something was more difficult than needed to create your own filesystem cache.

[ericmorand]

I reopened the issue. I think that using require.resolve may be a better approach anyway. Not sure I can find a test to demonstrate this though. I keep the issue opened to not forget giving it a try.

[ofabel]

Since ncc uses webpack under the hood you can use the native node require function with __non_webpack_require__. So I implemented my own cache by extending from the TwingCacheFilesystem:

class Cache extends TwingCacheFilesystem {
    load(key) {
        let modulePath = path.resolve(key);
        const requireFunc = typeof __non_webpack_require__ === 'function' ? __non_webpack_require__ : require;
        return new Promise((resolve) => {
            fs.stat(modulePath, (err) => {
                if (err) {
                    resolve(() => new Map);
                }
                else {
                    let cache = requireFunc.cache;
                    delete cache[requireFunc.resolve(modulePath)];
                    resolve(requireFunc(modulePath));
                }
            });
        });
    }
}