Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it easy to support variable weight using point size? #28

Open
ShixiangWang opened this issue Aug 12, 2020 · 4 comments
Open

Is it easy to support variable weight using point size? #28

ShixiangWang opened this issue Aug 12, 2020 · 4 comments

Comments

@ShixiangWang
Copy link
Contributor

ShixiangWang commented Aug 12, 2020

In the model, weight may contain important information. However, in current forestmodel, the point size is fixed.
So I wonder it would be nice to implement this.

main_plot <- main_plot +
geom_point(aes(x, y),
size = format_options$point_size, filter(mapped_data, !diamond),
colour = format_options$colour, shape = format_options$shape, na.rm = TRUE
)

@NikNakk
Copy link
Owner

NikNakk commented Aug 12, 2020

How would you propose scaling the points? I understand for a meta-analysis forest plot, but not one for a glm.

@ShixiangWang
Copy link
Contributor Author

@NikNakk Yeah, this is true. Some models may find it useful, but some others may not.

@NikNakk
Copy link
Owner

NikNakk commented Aug 12, 2020

Happy to review suggested code (or even just a suggested algorithm for calculating point size).

@ShixiangWang
Copy link
Contributor Author

Thanks, I will look into it in my spare time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants