Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Refactoring Modifiers and Writers #9

Conversation

cnoon
Copy link
Member

@cnoon cnoon commented Jul 19, 2016

This PR refactors the Writer and Modifier protocols to include a LogMessage prefix. There are two main reasons for these changes.

  1. We wanted to be more explicit with the protocol names to make their intent more clear. The previous names were so vague that they didn't really express intent clearly.
  2. We all agreed that Formatter was better than Modifier, but that LogMessageModifier was much better than Formatter. We also agreed that LogMessageModifier was much better than Willow.Formatter everywhere. In the end, we decided that additional verbosity to avoid conflicting with Foundation APIs was probably the best decision.

@EricAppel
Copy link
Contributor

Really like the clarity that these changes bring. 👍🏽

@cnoon cnoon added this to the 2.0.0 milestone Jul 23, 2016
@cnoon cnoon self-assigned this Jul 23, 2016
@cnoon
Copy link
Member Author

cnoon commented Jul 23, 2016

These changes have been merged into the swift3 branch. I'm going to close this PR out.

@cnoon cnoon closed this Jul 23, 2016
@cnoon cnoon deleted the feature/refactoring-modifiers-and-writers branch July 23, 2016 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants