Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enhancements to stats table #50

Closed
pinnapuvijay opened this issue Oct 16, 2023 · 3 comments
Closed

[FEATURE] Enhancements to stats table #50

pinnapuvijay opened this issue Oct 16, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@pinnapuvijay
Copy link

pinnapuvijay commented Oct 16, 2023

Is your feature request related to a problem? Please describe.
During our testing/adoption,

  1. we feel like a framework level flag to determine how the stats should be stored(relational vs nested constructs)
  2. Storing the stats also for the rules that pass would be helpful
  3. Capturing the actual value of the rule output( especially aggregations) so they can be referenced to determine if a rule is passed/failed in the subsequent executions of the rule. Basically, looking at historical metric(last 7 days avg, etc) to determine the status of the rule.
  4. Not all rules get executed even if one of the rules marked as FAIL fails. A framework level flag to exit or continue with the other rules when a rule fails would.
  5. stats for the rule that is marked as FAIL need to be logged as well when the rule fails.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
May be a stats_detail that supplements the stats table will also be a good alternative. This detail table will be in relational format and would also contain granular data that is requested above

Additional context
Add any other context or screenshots about the feature request here.

@pinnapuvijay pinnapuvijay added the enhancement New feature or request label Oct 16, 2023
@asingamaneni
Copy link
Collaborator

@pinnapuvijay Thanks for creating this issue. Except for the first point I agree with all the new feature requests.
We don't need to have stat's table as relational and nested constructs can easily be unwrapped, as well as if teams try to interchange the settings there will be problems with table schema.

Can you please show how you would like to take the implementation for the remaining and flags you would introduce as part of this pr.

@pinnapuvijay
Copy link
Author

pinnapuvijay commented Dec 7, 2023

I would assume teams who choose one or the other to begin with will remain to continue to stick to it, unless it is really not working for them. That's why, i am proposing to have a framework level flag with enough documentation on how either of the options benefits them so teams can make an educated choice to begin their journey with Spark Expectations. Even if they choose to switch down the road, i understand there would be schema changes but i would be interested to know how it cause confusion or complexities with switching.

@asingamaneni
Copy link
Collaborator

I would assume teams who choose one or the other to begin with will remain to continue to stick to it, unless it is really not working for them. That's why, i am proposing to have a framework level flag with enough documentation on how either of the options benefits them so teams can make an educated choice to begin their journey with Spark Expectations. Even if they choose to switch down the road, i understand there would be schema changes but i would be interested to know how it cause confusion or complexities with switching.

Can you please illustrate how the data model is going to be for the stats table. Want to review before proceeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants