-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pileup peaks added #275
Pileup peaks added #275
Conversation
… file. The parameters are defined in xrf_model. There will be some conflicts if define values in multiple places. Change in trim function to include boundary values.
…x, y sent to this function are within interested range already
@@ -237,7 +237,8 @@ | |||
'bound_type': 'lohi', | |||
'description': 'Incident E [keV]', | |||
'max': 13.0, | |||
'min': 9.0, 'value': 11.0}, | |||
'min': 9.0, | |||
'value': 10.0}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the value change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually 10keV is the most common value. Not typo.
This function sets the parameter hints on one model given a second model and a list of parameter names to copy.
Elastic peak mnt
if k_temp in fit_results.values: | ||
param[k]['value'] = float(fit_results.values[k_temp]) | ||
elif k == 'non_fitting_values': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that non_fitting_values
had been removed all together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current plan is to save all the values in one config file.
I think this is ready to go. @tacaswell ? |
Ready to review, @tacaswell ? |
In this PR, I added pileup peaks for fitting. Pileup peak is the combination of two different elemental lines.