Cdi plot #294
Merged
Cdi plot #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -281,6 +283,10 @@ def cdi_recon(diffracted_pattern, sample_obj, sup, | |||
| n_iterations : int, optional | |||
| number of iterations to run. | |||
| default is 1000. | |||
| plot_function : function, optional | |||
| plotting function | |||
There was a problem hiding this comment.
Note that this is a callback function that expects to receive these four objects: sample_obj, obj_error, diff_error, sup_error
|
Done. thanks! |
| @@ -45,6 +45,7 @@ | |||
| import numpy as np | |||
| import time | |||
| from scipy.ndimage.filters import gaussian_filter | |||
| import matplotlib.pyplot as plt | |||
|
Done! |
| @@ -281,6 +282,12 @@ def cdi_recon(diffracted_pattern, sample_obj, sup, | |||
| n_iterations : int, optional | |||
| number of iterations to run. | |||
| default is 1000. | |||
| cb_function : function, optional | |||
| This is a callback function that expects to receive these | |||
| four objects: sample_obj, obj_error, diff_error, sup_error | |||
There was a problem hiding this comment.
You should also list the expected types. Imaging reading this doc string with out having read the function, but wanting to write a callback to plug into this.
|
Two minor doc/naming comments, but 👍 to merge as soon as those are fixed. |
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add plotting function to cdi reconstruction.