Stageless

[freiksenet]

Did a stab at implementing stageless. There is some cursed hairiness with ExclusiveSystem traits in bevy/iyes_loopless, so sorry for hairy code at places.

Note that this requires your state to be pre-initialized before AssetLoader, I think it's limitation of how iyes_loopless does State.

[freiksenet]

Fixed tests, whew that was fun.

[NiklasEi]

Slowly the crate has too many feature flags 😆
Maybe we could move some of the now duplicated systems into extra files? Then we have the stageless stuff a bit more separated and need less cfg attributes checking for the feature. E.g. have one mod behind a #[cfg(feature = "stageless")] containing all the stageless systems and one mod behind #[cfg(not(feature = "stageless"))] containing all the old systems.

[freiksenet]

Thanks, will fix the comments.

[NiklasEi]

I understood now why the tests are red. Could you split the CI job into one test job for bevy_asset_loader_derive and one for bevy_asset_loader, please?
You can add --package bevy_asset_loader{_derive} to the cargo hack command to only run in that package. The command for bevy_asset_loader_derive does not need any feature grouping.

[freiksenet]

Should be good now :)

[NiklasEi]

It looks like a cargo fmt --all run is missing.

If you've had enough of fighting with the CI, I could also merge the PR. The CI issues can still be fixed on the stageless branch. Just say the word 🙂
Thank you for all the work!

[freiksenet]

Haha, this is fine, super smooth comparing to CI at my day job.

[freiksenet]

I don't understand, it passes on my machine on windows O_O

[NiklasEi]

Could you try adding --clean-per-run to the cargo hack command?

[NiklasEi]

I also don't understand what's happening here. The test is green, but the process fails. Locally everything seems fine, too.
I will merge and take a look at the CI setup separately.

Thanks again for the implementation 👍