Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank search results list, despite finding matches #34

Open
tigersof opened this issue Mar 16, 2024 · 3 comments
Open

Blank search results list, despite finding matches #34

tigersof opened this issue Mar 16, 2024 · 3 comments

Comments

@tigersof
Copy link

Hi,

I've been using this extension quite a while now, and up until now it has been working as intended (as far as I can see!). I've suddenly encountered a problem where when entering a search term, results in a blank list despite recognising and indicating the expected X number of matches. It is therefore currently unusable.

Any ideas what could be causing this, and is there an easy fix for it?

@tigersof tigersof changed the title This extension is (suddenly) not working for me any more Blank search results list, despite finding matches Mar 16, 2024
@piroor
Copy link
Contributor

piroor commented Apr 30, 2024

@NiklasGollenstede TST 4.0 and later generates HTML elements only near the viewport, so showing/hiding search results with a CSS hack is not effective anymore. Instead we need to show/hide tabs via WebExtensions API.
Here is an experimental branch for that, but I know it is not good. I hope it helps your development.

https://github.com/piroor/tst-search/tree/support-tst-4
piroor@20188d2

@fffmmm
Copy link

fffmmm commented May 6, 2024

Yes, this is sad. TST Search only shows matching results of pinned tabs, non-pinned tab match results are not returned, however the match total is correct seems to include the tabs that are not shown.

@miltuss
Copy link

miltuss commented May 8, 2024

@NiklasGollenstede TST 4.0 and later generates HTML elements only near the viewport, so showing/hiding search results with a CSS hack is not effective anymore. Instead we need to show/hide tabs via WebExtensions API. Here is an experimental branch for that, but I know it is not good. I hope it helps your development.

https://github.com/piroor/tst-search/tree/support-tst-4 piroor@20188d2

Hello, this patch is not working for me. Can you provide the .xpi file to repair TST-search?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants