Prettier PR for VSCoder users? #58

cameronelliott · 2021-09-03T23:10:12Z

This seems like a fantastic project, thanks for implementing it.

I am more of a backend Go developer, and try to stay away from NPM/Yarn, Rollup, etc, etc

It would be really wonderful if this was part of Prettier, and
so every VSCode user could this plugin without having to touch NPM.
Just by using a standard VScode extension:
https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode
(NPM is great, until you do something wrong, and you don't know how to fix it)

Maybe it is not meant to be due to do logistical reasons, but I wanted to throw it out there,
in case.

cameronelliott · 2021-09-03T23:17:58Z

One more thought, an example of a test-case in the README that shows a before & after example,
so users unfamiliar with prettier-plugin-go-template can see if they have installed it correctly would be super helpful.

For example, in my case, I did:

And if I now run:

npx prettier sample.html

with the input: sample.html

<html>
<script>
{{if }}
Whatever.
{{else }}
Psych.
{{end }}
</script>
</html>

I get the following on Stdout:

<html>
<script>
{{if }}
Whatever.
{{else }}
Psych.
{{end }}
</script>
</html>

Which seems wrong, (it is unindented to start) but I am so unfamiliar with npm/npx, I don't know the issue.

cameronelliott · 2021-09-03T23:37:44Z

I just found this: prettier/prettier#6034
😢

cameronelliott · 2021-09-03T23:45:40Z

Okay, I guess my test cases are failing because the {{foo}} inside the <script> block causes the formatter to abort formatting.

NiklasPor · 2021-10-02T08:51:13Z

cameronelliott · 2021-10-03T06:18:49Z

@NiklasPor I don't think I'm using this enough to justify me asking you to do that, but maybe if other people come along and want it to it makes sense.
I'm just kind of thrilled this exists for go templates in the first place.

whatsupbros · 2022-02-02T11:17:51Z

Regarding VSCode, I could consider publishing the plugin as an additional VSCode extension.

Please, do!

I.e. Grafana Unified Alerting Templates are currently using Golang Template language, and it would be really useful.

Currently, no golang-template formatter available for VS Code in Marketplace.

NiklasPor · 2022-03-31T20:18:02Z

If anyone is still interested in using it globally (without installing it to each repository), you'll need to:

Have node & npm installed
Run npm i -g prettier prettier-plugin-go-template
Find where your node modules are by running npm root -g ➡️ /Users/niklaspor/.nvm/versions/node/v16.13.2/lib/node_modules
Configure your VSCode settings to use your global prettier: "prettier.prettierPath": "/Users/niklaspor/.nvm/versions/node/v16.13.2/lib/node_modules/prettier"
Setup your .prettierrc as it's described inside the README.md

I'm still considering publishing a VSCode extension for the users who're not interested in the node cosmos at all. Especially as the setup above is more than just a click 😁

NiklasPor · 2022-04-01T19:27:56Z

@cameronelliott there are now examples in the README.md and you can play with the plugin on the playground 🚀

exofoliohq · 2022-10-06T13:25:22Z

I'm still considering publishing a VSCode extension for the users who're not interested in the node cosmos at all. Especially as the setup above is more than just a click 😁

Never used node.js before, and had it all installed just for this pretty software piece of yours. It was interesting, but having the prettier plugin go template live next to the other vscode extensions would be smoother for sure

Cheers !

robbycuenot · 2023-01-10T15:59:51Z

I'm still considering publishing a VSCode extension for the users who're not interested in the node cosmos at all. Especially as the setup above is more than just a click 😁

Never used node.js before, and had it all installed just for this pretty software piece of yours. It was interesting, but having the prettier plugin go template live next to the other vscode extensions would be smoother for sure

Cheers !

Agree with this 100% -- Love the plugin, but would love it even more without having to install node. Great work regardless!

pinkpigeonltd · 2023-11-01T12:23:21Z

When I attempt this, I get:

["INFO" - 12:20:11] Extension Name: esbenp.prettier-vscode.
["INFO" - 12:20:11] Extension Version: 10.1.0.
["INFO" - 12:20:20] Attempted to load Prettier module from /usr/lib/node_modules/prettier/
["ERROR" - 12:20:20] Failed to load module. If you have prettier or plugins referenced in package.json, ensure you have run `npm install`
["ERROR" - 12:20:20] Cannot find Prettier package.json

I have tried this with /usr/lib/node_modules/prettier (no trailing slash) which made no difference. Going to that directory, I can see prettier is right there, along with a package.json. Not sure how to address this. Any ideas? This is on Manjaro, if that helps.

Quick edit:

It would appear that the first part of this issue can be addressed by doing this:

"prettier.prettierPath": "/usr/lib/node_modules/prettier/index.cjs"

However, the following issue now occurs:

["ERROR" - 12:36:50] Error resolve node module 'prettier-plugin-go-template'
Error: Error resolve node module 'prettier-plugin-go-template'

Despite this also having been installed via npm i -g and sitting right next to prettier in /usr/lib/node_modules

One last edit:

I have now installed both prettier and the go template plugin directly in my project folder, to see if I could get it working like that. Now, however, I am getting this error:

["ERROR" - 12:41:44] Error formatting document.
["ERROR" - 12:41:44] An error occured during printing. Found invalid node root.
Error: An error occured during printing. Found invalid node root.
    at Object.print (/fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier-plugin-go-template/lib/index.js:65:19)
    at callPluginPrintFunction (file:///fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier/index.mjs:17846:20)
    at printAstToDoc (file:///fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier/index.mjs:17801:22)
    at async coreFormat (file:///fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier/index.mjs:18111:14)
    at async formatWithCursor (file:///fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier/index.mjs:18309:14)
    at async Module.format2 (file:///fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier/index.mjs:21504:25)

I am not entirely sure what that means unfortunately.

technodrome · 2024-04-05T15:38:25Z

Same error as user above.

D-4-N · 2024-04-28T00:07:57Z

One last edit:

I have now installed both prettier and the go template plugin directly in my project folder, to see if I could get it working like that. Now, however, I am getting this error:

["ERROR" - 12:41:44] Error formatting document.
["ERROR" - 12:41:44] An error occured during printing. Found invalid node root.
Error: An error occured during printing. Found invalid node root.
    at Object.print (/fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier-plugin-go-template/lib/index.js:65:19)
    at callPluginPrintFunction (file:///fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier/index.mjs:17846:20)
    at printAstToDoc (file:///fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier/index.mjs:17801:22)
    at async coreFormat (file:///fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier/index.mjs:18111:14)
    at async formatWithCursor (file:///fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier/index.mjs:18309:14)
    at async Module.format2 (file:///fast_ssd/Projects/pink_pigeon/defaultsitestructure/node_modules/prettier/index.mjs:21504:25)

I am not entirely sure what that means unfortunately.

I can confirm the above mentioned error is still present on the following:

Environment:

VSCode: 1.88.1
Prettier: 3.2.5
Plugin: 0.0.15

It seems to be something related to the way the GoTemplate AST is being generated or interpreted by Prettier. Maybe an API change?

@NiklasPor any hopes on feedback on this, or is the project no longer maintained?

Thanks

kristofk01 · 2024-06-08T08:45:01Z

I'm also having this problem

emilchr · 2024-06-24T06:43:03Z

Same issue here.

NiklasPor added the enhancement New feature or request label Mar 28, 2022

behnamgolds mentioned this issue May 9, 2024

.prettierrc format problem in documentation #110

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prettier PR for VSCoder users? #58

Prettier PR for VSCoder users? #58

cameronelliott commented Sep 3, 2021

cameronelliott commented Sep 3, 2021 •

edited

Loading

cameronelliott commented Sep 3, 2021

cameronelliott commented Sep 3, 2021

NiklasPor commented Oct 2, 2021

cameronelliott commented Oct 3, 2021

whatsupbros commented Feb 2, 2022

NiklasPor commented Mar 31, 2022

NiklasPor commented Apr 1, 2022 •

edited

Loading

exofoliohq commented Oct 6, 2022

robbycuenot commented Jan 10, 2023

pinkpigeonltd commented Nov 1, 2023 •

edited

Loading

technodrome commented Apr 5, 2024

D-4-N commented Apr 28, 2024

kristofk01 commented Jun 8, 2024

emilchr commented Jun 24, 2024

Prettier PR for VSCoder users? #58

Prettier PR for VSCoder users? #58

Comments

cameronelliott commented Sep 3, 2021

cameronelliott commented Sep 3, 2021 • edited Loading

cameronelliott commented Sep 3, 2021

cameronelliott commented Sep 3, 2021

NiklasPor commented Oct 2, 2021

cameronelliott commented Oct 3, 2021

whatsupbros commented Feb 2, 2022

NiklasPor commented Mar 31, 2022

NiklasPor commented Apr 1, 2022 • edited Loading

exofoliohq commented Oct 6, 2022

robbycuenot commented Jan 10, 2023

pinkpigeonltd commented Nov 1, 2023 • edited Loading

technodrome commented Apr 5, 2024

D-4-N commented Apr 28, 2024

kristofk01 commented Jun 8, 2024

emilchr commented Jun 24, 2024

cameronelliott commented Sep 3, 2021 •

edited

Loading

NiklasPor commented Apr 1, 2022 •

edited

Loading

pinkpigeonltd commented Nov 1, 2023 •

edited

Loading