Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Data to Variable #67

Closed
Tracked by #61
NiklasRosenstein opened this issue Feb 23, 2022 · 0 comments · Fixed by #68
Closed
Tracked by #61

Rename Data to Variable #67

NiklasRosenstein opened this issue Feb 23, 2022 · 0 comments · Fixed by #68
Assignees
Labels
component: docspec The main docspec module, or the docspec JSON specification. type: improvement An improvement to an existing feature.
Milestone

Comments

@NiklasRosenstein
Copy link
Owner

Is your feature request related to a problem? Please describe.

The name "data" is too generic, and "variable" expresses more closely what the datastructure resembles (information about a value declaration and/or assignment to a name). We already have a semantic hint that could express if the variable is actually a constant.

Describe the solution you'd like

N/A

Describe alternatives you've considered

  • "value", but it does not convey that information about the name of the value is available as well. Also a pure variable declaration with a type hint does not even have a value so in that case the name would make no sense at all.
@NiklasRosenstein NiklasRosenstein self-assigned this Feb 23, 2022
@NiklasRosenstein NiklasRosenstein added component: docspec The main docspec module, or the docspec JSON specification. type: improvement An improvement to an existing feature. and removed type: feature request A new feature. labels Feb 23, 2022
@NiklasRosenstein NiklasRosenstein added this to the Docspec 2.0.0 milestone Feb 23, 2022
@NiklasRosenstein NiklasRosenstein linked a pull request Feb 23, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: docspec The main docspec module, or the docspec JSON specification. type: improvement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant