Add option to Render the heading#1 for letting readthedocs to generate TOC automatically #214 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasRosenstein
requested changes
Oct 3, 2021
There was a problem hiding this comment.
Hey @t6847kimo , thanks for the PR. I have to think about this a bit more. The Renderer.render() method does not accept a page_title argument and I'm unsure if I want to add it to the interface.
|
I just noticed that I even suggested this 🥲
|
Co-authored-by: Niklas Rosenstein <rosensteinniklas@gmail.com>
Co-authored-by: Niklas Rosenstein <rosensteinniklas@gmail.com>
|
Hi, may I know the current status? |
Merged
NiklasRosenstein
added a commit
that referenced
this pull request
Dec 12, 2021
NiklasRosenstein
added a commit
that referenced
this pull request
Dec 12, 2021
* Add render_page_title option for markdown * Update src/pydoc_markdown/contrib/renderers/markdown.py Co-authored-by: Niklas Rosenstein <rosensteinniklas@gmail.com> * Update src/pydoc_markdown/contrib/renderers/markdown.py Co-authored-by: Niklas Rosenstein <rosensteinniklas@gmail.com> * add new SinglePageRenderer interface which is implemented by MarkdownRenderer to allow passing a page title from the Page class * enable `render_page_title` for Pydoc-Markdown config * update prerender step * feature: Add `render_page_title` option. (@t6847kimo) fixes #214, #216 Co-authored-by: Yancy Chien <t6847kimo@gmail.com>
|
Hey @t6847kimo , sorry for the long silence. I've made a few changes before merging, that's why I create a new PR for it. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, sorry for late response.
Please take a look at it, thanks!