Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy of license file from parent folder in sdist doesn't work #21

Closed
NiklasRosenstein opened this issue Aug 10, 2021 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@NiklasRosenstein
Copy link
Owner

In a mono repository, a package can inherit the license file of the repo by temporarily copying it into the package folder during setup.py. This doesn't work anymore. Looking at databind.core==1.1.3's setup.py, I can see

_tempcopy('../../LICENSE.txt', 'LICENSE.txt')

I belive that is one ../ too many.

@NiklasRosenstein NiklasRosenstein added the bug Something isn't working label Aug 10, 2021
@NiklasRosenstein NiklasRosenstein self-assigned this Aug 10, 2021
@NiklasRosenstein
Copy link
Owner Author

commit f81b377845ae3c46676a05074e41ddb95e1d56eb (HEAD -> develop, tag: 1.1.3, origin/develop, origin/HEAD)
Author: Niklas Rosenstein <rosensteinniklas@gmail.com>
Date:   Tue Aug 10 03:00:53 2021 +0200

    (databind) bump version to 1.1.3

diff --git a/databind.core/setup.py b/databind.core/setup.py
index 40f3287..b0539cf 100644
--- a/databind.core/setup.py
+++ b/databind.core/setup.py
@@ -17,7 +17,7 @@ def _tempcopy(src, dst):
     atexit.register(lambda: os.remove(dst))
 
 
-_tempcopy('../LICENSE.txt', 'LICENSE.txt')
+_tempcopy('../../LICENSE.txt', 'LICENSE.txt')
 
 readme_file = 'README.md'
 if os.path.isfile(readme_file):
@@ -38,10 +38,12 @@ requirements = [
 test_requirements = [
   'pytest',
 ]
+extras_require = {}
+extras_require['test'] = test_requirements
 
 setuptools.setup(
   name = 'databind.core',
-  version = '1.1.2',
+  version = '1.1.3',
   author = 'Niklas Rosenstein',

@NiklasRosenstein
Copy link
Owner Author

Running shut mono update causes the bad path, but shut pkg update fixes it.

NiklasRosenstein added a commit to NiklasRosenstein/python-databind that referenced this issue Aug 10, 2021
…ein/slap#21 fixed, now the LICENSE.txt is again included in the `sdist`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant