Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate MANIFEST.in content (each line matches at least one file) in shut pkg checks #38

Closed
NiklasRosenstein opened this issue Sep 15, 2021 · 1 comment
Closed

Validate MANIFEST.in content (each line matches at least one file) in shut pkg checks #38

NiklasRosenstein opened this issue Sep 15, 2021 · 1 comment
Assignees
@NiklasRosenstein
Labels
enhancement New feature or request

Comments

@NiklasRosenstein
Copy link
Owner

Lines that don't have any effect in MANIFEST.in do not cause an error or easily surface-able warning when building the package. The Shut package checks should validate that each line in the manifest serves a purpose. Lines that do not may be a mistake that needs to be corrected by the user.
@NiklasRosenstein NiklasRosenstein added the enhancement New feature or request label Sep 15, 2021
@NiklasRosenstein NiklasRosenstein self-assigned this Sep 15, 2021
NiklasRosenstein added a commit that referenced this issue Sep 15, 2021
@NiklasRosenstein
grr, I should really prioritize #38
e50485c
@NiklasRosenstein
Copy link
Owner Author

Slam now relies on other Python build tools, and tools like Poetry or Flit don't need a MANIFEST.in in the repository anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiklasRosenstein NiklasRosenstein

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NiklasRosenstein