Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading project dependencies is a step that can be avoided for most Slap commands #50

Closed
NiklasRosenstein opened this issue Apr 8, 2022 · 1 comment
Closed

Loading project dependencies is a step that can be avoided for most Slap commands #50

NiklasRosenstein opened this issue Apr 8, 2022 · 1 comment
Assignees
@NiklasRosenstein
Labels
enhancement New feature or request

Comments

@NiklasRosenstein
Copy link
Owner

The project dependencies are loaded with every invocation of Slap right now because of how Project._get_projects() already orders the project list topologically. Most Slap commands don't care about the order (like slap release, etc.) and we can skip loading the dependencies if we instead create a separate API to retrieve the projects in topological order explicitly.
@NiklasRosenstein NiklasRosenstein added the enhancement New feature or request label Apr 8, 2022
@NiklasRosenstein NiklasRosenstein self-assigned this Apr 8, 2022
@NiklasRosenstein
Copy link
Owner Author

Fixed in 5f75071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiklasRosenstein NiklasRosenstein

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NiklasRosenstein