Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuclearCraft Ingot Former has a very limited set of recipes. #1408

Closed
ghost opened this issue Nov 5, 2019 · 11 comments · Fixed by #1419
Closed

NuclearCraft Ingot Former has a very limited set of recipes. #1408

ghost opened this issue Nov 5, 2019 · 11 comments · Fixed by #1419
Labels
Script This issue relates to scripts in general Status: Ready For Testing In-game testing of the issue is required Suggestion

Comments

@ghost
Copy link

ghost commented Nov 5, 2019

Modpack Version
1.71

Issue
The Ingot Former has a very limited set of alloys and metals that it can make, compared to the Tinker's Smeltery and casting system.
I believe Ingot Former and Smelter recipes share a similar recipe format, and they both have CT Support, so exporting a list from one to the other doesn't seem too difficult a fix, though I may be mistaken.

@NielsPilgaard NielsPilgaard added Script This issue relates to scripts in general Suggestion labels Nov 5, 2019
@NielsPilgaard
Copy link
Collaborator

It'd be nice if exporting recipes from one machine to another was a thing, but sadly this has to be done manually, as everything else :P I probably won't get around to do this tbh, if anyone wants to make a pull request I'll happily merge it.

@MaxNeedsSnacks
Copy link
Collaborator

MaxNeedsSnacks commented Nov 7, 2019

this might be doable using kubejs scripts actually, since you can work with java types directly there and tinkers DOES have a registry of casting recipes

@NielsPilgaard
Copy link
Collaborator

Adding KubeJS for that one thing would be a bit overkill though xD

@MaxNeedsSnacks
Copy link
Collaborator

it's quite lightweight actually ^^
i get what you mean though, although it does open up more possibilities for more recipe adapters like this in the future

@NielsPilgaard
Copy link
Collaborator

Maybe for 1.14 :D

@MaxNeedsSnacks
Copy link
Collaborator

MaxNeedsSnacks commented Nov 7, 2019

side note: i tried doing this anyway just for fun and it turns out it's not automatable after all, anyways, or at least not easily, due to just how late tinkers' actually registers smelting recipes

@NielsPilgaard
Copy link
Collaborator

Ah alright :/

@pjc21
Copy link
Contributor

pjc21 commented Nov 15, 2019

This is what I found missing from the NC Ingot Former that the Tinkers Smeltery has, I only increased the multiplier for the Demon Metal Ingot as it seems to be the only one that needs a lot more heat to melt in tinkers compared to the others.

# Add missing ingots/bricks to ingot former
	//Brick
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:clay>*144, <minecraft:brick>, 1.0, 1.0]);
	//Starmetal Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:astral_starmetal>*144, <astralsorcery:itemcraftingcomponent:1>, 1.0, 1.0]);
	//Demon Metal Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:xu_demonic_metal>*144, <extrautils2:ingredients:11>, 2.0, 2.0]);
	//Enchanted Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:xu_enchanted_metal>*144, <extrautils2:ingredients:12>, 1.0, 1.0]);
	//Evil Infused Iron Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:xu_evil_metal>*144, <extrautils2:ingredients:17>, 1.0, 1.0]);
	//Fire Dragonsteel Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:dragonsteel_fire>*144, <iceandfire:dragonsteel_fire_ingot>, 1.0, 1.0]);
	//Ice Dragonsteel Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:dragonsteel_ice>*144, <iceandfire:dragonsteel_ice_ingot>, 1.0, 1.0]);
	//Pink Slime Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:molten_reinforced_pink_slime>*144, <industrialforegoing:pink_slime_ingot>, 1.0, 1.0]);
	//Refined Obsidian Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:refinedobsidian>*144, <mekanism:ingot>, 1.0, 1.0]);
	//Refined Glowstone Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:refinedglowstone>*144, <mekanism:ingot:3>, 1.0, 1.0]);
	//Base Essence Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:base_essence>*144, <mysticalagriculture:crafting:32>, 1.0, 1.0]);
	//Psimetal Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:psimetal>*144, <psi:material:1>, 1.0, 1.0]);
	//Fiery Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:fierymetal>*144, <twilightforest:fiery_ingot>, 1.0, 1.0]);
	//Seared Brick
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:stone>*144, <tconstruct:materials>, 1.0, 1.0]);
	//Mud Brick
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:dirt>*144, <tconstruct:materials:1>, 1.0, 1.0]);
	//Elementium Ingot
	mods.nuclearcraft.ingot_former.addRecipe([<liquid:elementium>*144, <botania:manaresource:7>, 1.0, 1.0]);

@MaxNeedsSnacks
Copy link
Collaborator

thaat looks good to me ^^

feel free to PR it and i'll test it ingame

@pjc21
Copy link
Contributor

pjc21 commented Nov 16, 2019

Cool, PR done - first time doing a PR, so think I've done it correctly but let me know if not.

@MaxNeedsSnacks
Copy link
Collaborator

nice, i'm gonna try to check it out when i can ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Script This issue relates to scripts in general Status: Ready For Testing In-game testing of the issue is required Suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants