Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two By Two Advancement Showing Strange Results #3173

Closed
zedekblue opened this issue Sep 4, 2021 · 4 comments
Closed

Two By Two Advancement Showing Strange Results #3173

zedekblue opened this issue Sep 4, 2021 · 4 comments

Comments

@zedekblue
Copy link

Modpack Version

0.5.11

Describe your issue

I have been working on the breeding & taming advancements and noticed some... strange progress in the advancements tab, which is all I really have to go off of for progress.
Capture
As you can see, I have bred 44, yet it only counts 41. Furthermore, it shows 11 remaining, yet only 10 left until 51.

To make matters more complicated, as you can see in The Spreadsheet I've made, I have successfully bred 7 additional mobs which did not count towards this advancement.

My question is:
Is this list autogenerated or manually created? Is this behavior intentional, with some mobs left out?
Can you confirm if those 7 mobs should have counted or not?
Considering this is an official e6 challenge quest I am having a difficult time finding anyone else who has any information on completing it.

Regardless, I thought you should know this is happening in case it needs to be fixed.
Thank you!

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

Server has been updated from 0.5.9 -> 0.5.10 -> 0.5.11 in case that may be a contributing factor.

Did the issue happen in singleplayer or on a server?

Server

@zedekblue zedekblue added the Bug label Sep 4, 2021
@NielsPilgaard
Copy link
Collaborator

Thanks for the report! @ochotonida do you have any light to shed on this? :)

@ochotonida
Copy link
Contributor

Thanks for the very detailed report, the spreadsheet helped a lot :).

The lists of mobs that count towards the taming & breeding advancements are manually maintained, so there's always a possibility I missed something. From the 7 mobs you couldn't get to count, cockroach is the only one that should have counted. Tarantula hawk breeding isn't possible to detect afaik, so I can't add that one to the advancement. The other 5 simply weren't added to the list. The book from Alex's Mobs doesn't mention breeding for 4 of these, so I'm not surprised I missed them.

The incorrect count is caused by environmental. Its mobs currently don't actually count toward the advancement despite showing up in the list, this is also fixed in my PR.

@zedekblue
Copy link
Author

zedekblue commented Sep 5, 2021

From the 7 mobs you couldn't get to count, cockroach is the only one that should have counted.

I retried, and looks like it worked. Maybe it doesn't like cockroaches spawned from a mob duplicator, or maybe I killed them too soon afterwards, I dunno.

The book from Alex's Mobs doesn't mention breeding for 4 of these, so I'm not surprised I missed them.

I was pretty surprised they were breedable, myself. I started just trying to feed everything after a while.

The incorrect count is caused by environmental. Its mobs currently don't actually count toward the advancement despite showing up in the list, this is also fixed in my PR.

Thank you for your work!

I'll go ahead and close since the PR should resolve the actual issue. (even though I still have yet to find the last 2 breedables... 😭)

@MuteTiefling MuteTiefling reopened this Sep 5, 2021
@MuteTiefling
Copy link
Contributor

We leave them open until the update containing the fix is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants