Add custom values to names.cfg #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the Apotheosis bosses all have default equipment and names, excluding netherite which has been removed from being possible. This proposed change adds a number of materials to the pool by giving them names, trying not to be overpowered and appreciating the current values for what non-bosses may spawn with. This also adds a bunch of prefixes to boss names to add a bunch of variety (I'm tired of every boss I meet having the prefix Doctor, for example) and new name-parts for some additional random names. As a side effect, I believe this will allow some of the named materials to appear as affix dungeon loot, but this is in my opinion desirable - as long as the materials are not overpowered compared to existing affix dungeon loot.
NielsPilgaard
approved these changes
Jan 2, 2021
|
Looks like some good changes, thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Apotheosis bosses all have default equipment and names, excluding netherite which has been removed from being possible.
This proposed change adds a number of materials to the pool by giving them names, trying not to be overpowered and appreciating the current values for what non-bosses may spawn with. This also adds a bunch of prefixes to boss names to add a bunch of variety (I'm tired of every boss I meet having the prefix Doctor, for example) and new name-parts for some additional random names.
As a side effect, I believe this will allow some of the named materials to appear as affix dungeon loot, but this is in my opinion desirable - as long as the materials are not overpowered compared to existing affix dungeon loot.