Travis failure after test for "array of nested inline table" was added to toml_test

[kaushalmodi]

toml_test was updated with commit toml-lang/toml-test@fb8ca06 on Nov 27.

The Travis tests for parsetoml run every week, and the next test day after Nov 27 happened to be Nov 20 when it failed: https://travis-ci.org/NimParsers/parsetoml/builds/461974298.

Test: nested-inline-table-array (valid)
../src/parsetoml.nim(883) parseValue
Error: unhandled exception: (1:14) unexpected character "{" [TomlError]
126 passed, 1 failed

/cc @PMunch

[PMunch]

The run before says "126 passed, 0 failed" while this one says "126 passed, 1 failed" so it appears a test was added for something we don't support. I'll look into it but the logic for inline arrays is pretty hairy and might need a complete rewrite to support this

[kaushalmodi]

@PMunch I meant exactly that, that the toml-test has been updated with new tests supporting a new TOML syntax.

I'll look into it but the logic for inline arrays is pretty hairy and might need a complete rewrite to support this

Thank you!

I am watching out for when toml-lang/toml-test#51 and toml-lang/toml-test#53 get merged in toml-test .. Those also seem to add tests for a lot of new syntax. But our CI uses the latest toml-test. So we will be auto-notified if any update in toml-test causes tests with parsetoml to fail.

[kaushalmodi]

Reminder: parsetoml to be reenabled in Nim ci once all tests pass; ref: nim-lang/Nim@af6539b

[PMunch]

Isn't this fixed?

[kaushalmodi]

I need to check why parsetoml was removed from Nim CI yesterday. I was lazy to just put a reminder to check that here.

[kaushalmodi]

@PMunch I see the same error today too.

Running nimble run_toml_test gives:

github.com/BurntSushi/toml-test
Test: nested-inline-table-array (valid)

/home/kmodi/sandbox/nim/parsetoml/src/parsetoml.nim(890) parseValue
Error: unhandled exception: (1:14) unexpected character "{" [TomlError]


127 passed, 1 failed

[PMunch]

Fixed by 988f6f5

[kaushalmodi]

@PMunch: wow! you are on a roll! Time to cut a new release of parsetoml.