Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid README.md example #5

Closed
pheki opened this issue Apr 16, 2021 · 1 comment
Closed

Invalid README.md example #5

pheki opened this issue Apr 16, 2021 · 1 comment

Comments

@pheki
Copy link
Contributor

pheki commented Apr 16, 2021

It looks like the example in the README.md getting started has been committed mid-changes:

It does not actually handle actual services (the onData argument is unused), but uses onError as if it was onData.

I suppose it was supposed to use onError like in the example

@Nimrodda
Copy link
Owner

You're right, it was indeed half done. It's fixed now. Thanks for reporting 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants