Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidation and organization of Font.swift #33

Merged
merged 1 commit into from Jan 31, 2019

Conversation

jrtibbetts
Copy link
Collaborator

  • Removed duplicate entries by interleaving fonts that are common to both platforms with ones that are found only on one or the other. This shaved off about 200 lines.
  • Alphabetized case names.
  • Added // MARKs to make it easier to navigate down the list.

All tests on both iOS and tvOS passed.

Removed duplicate entries by interleaving fonts that are common to both platforms with ones that are found only on one or the other.
Alphabetized cases.
Added // MARKs.
@jrtibbetts
Copy link
Collaborator Author

@Nirma, what do you think about this cleanup?

@Nirma
Copy link
Owner

Nirma commented Jan 31, 2019

@jrtibbetts this is great work! LGTM!

@Nirma Nirma merged commit ec48d1d into Nirma:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants