Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on nirs processing #117

Closed
Edouard2laire opened this issue Mar 10, 2020 · 3 comments · Fixed by #130
Closed

Clarification on nirs processing #117

Edouard2laire opened this issue Mar 10, 2020 · 3 comments · Fixed by #130
Assignees

Comments

@Edouard2laire
Copy link
Collaborator

Hi,

I open this issue so we can discuss the point raised by PR #115; especially when remove superficial noise using short-distance-channel.

As I understand, the main pipeline currently is something like :

  1. Import data
  2. Motion correction
  3. Detect bad channels
  4. MBLL or doD removing SSR
  5. IIR filtering
  6. Block average or GLM
  7. MEM or MNE (if computed dOD in 4) [done before 6 if GLM]

So if I understand it well, we should separate the superficial noise regression from the dOD computation and the pipeline would become :

In the case of block averaging :

  1. Import data
    2.a Detect bad channels
    2.b Motion correction
  2. Compute dOD
    4.a Regress out signal from short-distance channels (or external measurement such as accelerometers )
    4.b IIR filtering
  3. MBLL or step 7.
  4. Block average or GLM
  5. MEM or MNE (if skipped step 5)

With the exception that in case of GLM, you have to skype step 4.a and regress those signals out during GLM.

  1. Questions:

a. should we do motion correction after dOD computation? The advantage is that we don't have to worry about negative value induced by the process and remove the offset introduced in 2d34b50 that was making us worry during the mini-course presentation.

b. Line 499 in the computation of MBLL it is written, about the extinction coefficient, "%TODO: use same values as Alexis". Do you have any information concerning this TODO?

  1. Changes :
    Therefore here is the change we have to make :
    1/ we can remove MBLL_SRR and dOD_SRR
    2/ Add a process to regress out signal from the short-distance channel (can be change latter to also regress out signal from the accelerometer)
    3/ Change MBLL so it akes dOD as input.

Am I correct?

Best regards,
Edouard

@thomas-vincent
Copy link
Contributor

T

Hhh

o m

Channel

@Edouard2laire
Copy link
Collaborator Author

T

Hhh

o m

Channel

I think your message got lost in the labyrinth of the internet :)

@Edouard2laire
Copy link
Collaborator Author

Hi @thomas-vincent and @zhengchencai,
Do you have more time to look at this ?

This was referenced May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants