Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isLoading flag for a fallback #3

Merged
merged 5 commits into from Apr 9, 2022
Merged

Add isLoading flag for a fallback #3

merged 5 commits into from Apr 9, 2022

Conversation

NishuGoel
Copy link
Owner

  • Creates a writable for the isLoading attribute
  • checks if some locales are loaded, if none, set loading to true, false otherwise.
  • also checks for failed loading for a given locale, sets loading to true in cases of failed loading.

@NishuGoel NishuGoel self-assigned this Apr 8, 2022
adrai
adrai reviewed Apr 9, 2022
View reviewed changes
src/translation-store.ts Outdated Show resolved Hide resolved
@NishuGoel NishuGoel merged commit ffdc469 into main Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrai adrai adrai left review comments

Assignees

@NishuGoel NishuGoel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NishuGoel @adrai