Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings update from 0.6.3 #224

Closed
darix opened this issue Feb 28, 2017 · 1 comment
Closed

Warnings update from 0.6.3 #224

darix opened this issue Feb 28, 2017 · 1 comment
Labels

Comments

@darix
Copy link

darix commented Feb 28, 2017

I: Program is likely to break with new gcc. Try -fno-strict-aliasing.
W: nitrokey-app strict-aliasing-punning src/response.cpp:420, 422

If you cant fix the code for this warning just set the CFLAG mentioned in the error message for response.cpp.

The more detailed list:

--
src/ui/pindialog.h: In constructor 'PinDialog::PinDialog(const QString&, const QString&, Device*, PinDialog::Usage, PinDialog::PinType, bool, QWidget*)':
src/ui/pindialog.h:61:11: warning: 'PinDialog::_pinType' will be initialized after [-Wreorder]
--
           ^
src/ui/pindialog.cpp:35:27: warning:   base 'QDialog' [-Wreorder]
--
                           ^
src/ui/pindialog.cpp:32:1: warning:   when initialized here [-Wreorder]
--
src/response.cpp: In member function 'int Response::getResponse(Device*)':
src/response.cpp:420:68: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
--
                                                                    ^
src/response.cpp:422:66: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
--
src/ui/stick20-response-task.cpp: In member function 'void Stick20ResponseTask::done(int)':
src/ui/stick20-response-task.cpp:299:68: warning: statement has no effect [-Wunused-value]
--
src/utils/stick20hid.c: In function 'DebugAppendTimestampToLog':
src/utils/stick20hid.c:226:10: warning: unused variable 'CrString' [-Wunused-variable]
--
src/utils/hid_libusb.c: In function 'hid_open_path':
src/utils/hid_libusb.c:876:13: warning: variable 'num_devs' set but not used [-Wunused-but-set-variable]
--
@szszszsz
Copy link
Member

szszszsz commented Apr 7, 2017

Fixed in v1.0. Warnings now are treated as errors and halt the build.

@szszszsz szszszsz closed this as completed Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants